Ticket #1229 (reopened Enhancement)

Opened 4 years ago

Last modified 17 months ago

Using a proxy from GUI

Reported by: Rarok Owned by: timothy
Priority: Normal Milestone:
Component: Colloquy (Mac) Version: 2.1 (Mac)
Severity: Normal Keywords: proxy, GUI, badpatch
Cc: rob@…, grahamperrin, drewish@…, az@…

Description

Hi, I think It shouldn't be hard. I only want to make a suggestion:
Including the proxy selection from the GUI.
In the website I found how to use a proxy and/or ssh tunneling but they require to use the shell and some users don't know how to use it. I think that giving the option to consigure the proxy from the GUI should be very good for novice users.

Sorry for my bad english

Attachments

proxy.patch (9.3 KB) - added by robclark 4 years ago.
proxy-2.patch (9.3 KB) - added by robclark 3 years ago.
updated patch which doesn't break non-proxy case ;-)

Change History

Changed 4 years ago by robclark

follow-up: ↓ 4   Changed 4 years ago by robclark

  • cc rob@… added

the attached patch makes proxy support work... no additional GUI, it uses proxy settings configured in system preferences

  Changed 3 years ago by encro

This would be great if Rarok's patch could be landed on trunk.

Changed 3 years ago by robclark

updated patch which doesn't break non-proxy case ;-)

  Changed 3 years ago by timothy

  • status changed from new to assigned

I'll take a look at landing this.

in reply to: ↑ 1   Changed 3 years ago by xApple

This looks interesting.. how does one install such a patch ?

Colloquy really needs to follow the system wide proxy settings found in the system preferences...

  Changed 3 years ago by grahamperrin

  • cc grahamperrin added

/me watches this ticket:1229 and related ticket:747.

  Changed 3 years ago by Rinoa

  • status changed from assigned to closed
  • resolution set to duplicate

Duplicate of #747. The patch needs cleaned up in order for it to be landed.

  Changed 3 years ago by zach

  • status changed from closed to reopened
  • resolution duplicate deleted

This ticket allows for more kinds of proxies then just http, even if the patch is only for http proxies and should still be kept open.

  Changed 3 years ago by akempgen

  • keywords GUI, patch added; GUI removed

  Changed 3 years ago by zach

  • keywords badpatch added; patch removed

The patch shouldn't be modifying AsyncSocket... There's better ways to provide proxy support.

  Changed 3 years ago by psa

How should this be done? If I was implementing from scratch I'd use CFNetwork...

  Changed 2 years ago by drewish

  • cc drewish@… added

  Changed 17 months ago by witsch

  • cc az@… added
Note: See TracTickets for help on using tickets.