Ticket #1240 (closed Defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Colloquy sends malformed DCC SEND requests.

Reported by: nox Owned by: timothy
Priority: Normal Milestone: Colloquy 2.2
Component: Chat Core (File Transfer) Version: Built Source
Severity: Normal Keywords:
Cc:

Description

When you try to send a file to someone using one of the two most popular IRC clients (namely mIRC and Xchat), it fails and the client replies that your DCC SEND request.

Colloquy seems to add an extra parameter "T" to every DCC SEND request.

Here is a patch to fix this behaviour.

Attachments

Colloquy-malformed-dcc-send.diff (3.0 KB) - added by nox 4 years ago.

Change History

Changed 4 years ago by nox

Changed 4 years ago by ScottMac

The format is known as Turbo DCC, you add T to the end of the handshake, if anything a space is missing from a few of those places but that's all. I also think that mIRC doesn't support it but it should still work as normal and ignore the T.

 http://www.visualirc.net/tech-tdcc.php

Changed 4 years ago by timothy

  • status changed from new to closed
  • resolution set to fixed

Fixed in [3783].

Changed 4 years ago by timothy

ScottMac was correct, this is the Turbo DCC feature. We just had some missing spaces. This should make other clients work again.

Changed 3 years ago by Robby

  • milestone set to Colloquy 2.2
Note: See TracTickets for help on using tickets.