Ticket #1567 (new Enhancement)

Opened 3 years ago

Last modified 2 years ago

Make incompatible encoding message configurable.

Reported by: tru@… Owned by: timothy
Priority: High Milestone: Colloquy 2.4
Component: Colloquy (Mac) Version: Latest Nightly
Severity: Normal Keywords: patch
Cc: markus.magnuson@…, kiuzeppe@…

Description

In mixed channels (where people are using both iso-8859-1 and utf-8) the incompatible encoding message can be pretty annoying. So I made it configurable via defaults. Attached is the patch. Patch is also available on github  http://github.com/tru/colloquy where I svn-imported your whole repository.

Attachments

encoding.patch (2.0 KB) - added by tru 3 years ago.
Patch against svn revision 4285

Change History

Changed 3 years ago by tru

Patch against svn revision 4285

  Changed 3 years ago by jane

Thanks for the patch. Ideally the underlying problem should be fixed instead of just hiding the error message.

Out of curiosity, what kind of messages showed the incompatible encoding message in a room of users using utf8 and iso-8859-1?

  Changed 3 years ago by tru

I use utf-8 for all channels. But some users in the channels are using iso-8859-1 and some are using utf-8. This is because swedish channels are still pretty fragmented, not all clients handle utf-8. What irssi does is to recode everything to the terminal enocidng, you basically tell it to detect the incoming encoding and recode it to the terminal encoding and you give it a fallback in case of errors (which usually is iso-8859-1). See  http://www.iovene.com/the-ultimate-guide-for-utf-8-in-irssi-and-gnuscreen/ for more information.

Reality for most swedish IRC users are that people will have mixed charsets in the same channel and making sure that everyone speaks utf-8 will be suboptimal (or at least very very annoying).

  Changed 3 years ago by tru

Maybe the solution here is to be able to define a fallback encoding and if that also fails we could add the (incompatible encoding) string?

  Changed 3 years ago by alimony

  • cc markus.magnuson@… added

Yes, this is so annoying. There should be a way to hide it in the official version of Colloquy, please accept this patch into trunk.

follow-up: ↓ 6   Changed 2 years ago by kiuzeppe

  • cc kiuzeppe@… added
  • priority changed from Normal to High
  • milestone set to Colloquy 2.4

Yeah, please fix this. It is really frustrating to download source & fix this bug every single time you release new version. I understand that those using only english don't see this as problem but it's really big problem for rest of us.

It's really easy to fix anyways so just do it.

in reply to: ↑ 5   Changed 2 years ago by jane

Replying to kiuzeppe:

It's really easy to fix anyways so just do it.

How does one fix this? The patch only hides it. If you have a patch to actually fix the issue, that'd be great!

Note: See TracTickets for help on using tickets.