Ticket #1786
(new Defect)
Nick password not retrieved from keychain connecting from Join window
| Reported by: |
SidneySM |
Owned by: |
timothy
|
|
Priority:
|
Normal
|
Milestone:
|
|
|
Component:
|
Colloquy (Mac)
|
Version:
|
2.3 (Mac)
|
|
Severity:
|
Normal
|
Keywords:
|
keychain, password, nickserv, nick
|
|
Cc:
|
|
|
|
When connecting to a server from the Join window, Colloquy prompts for a password when poked by NickServ instead of using one from the keychain.
Attachments
-
MVConnectionsController.patch
(2.0 KB) - added by SidneySM
2 years ago.
-
Patch
-
colloquy_1786.txt
(12.3 KB) - added by SidneySM
2 years ago.
-
Second attempt at patching
-
colloquy_1786.patch
(12.3 KB) - added by SidneySM
2 years ago.
-
Second attempt at patching (extensions are fun)
-
colloquy_1786.2.patch
(12.1 KB) - added by SidneySM
2 years ago.
-
Moves the connection password into MVChatConnection, most subclasses already implemented it, and standardizes setting a nil password (looking at you, MVICBChatConnection). Adds a delegate (MVChatConnectionPasswordSource) to MVChatConnection to provide password and nicknamePassword (i.e. from the keychain). Third revision calls delegate on _willConnect instead of on first access to password and nicknamePassword. This is consistent with previous behavior and more predictable. If no passwordSource was set, behavior does not change at all. Changed desktop Colloquy's MVConnectionsController to be a passwordSource.
Change History
